Issue918 #952
Open
Issue918 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error check added for --sensorWidth option --defaultFocal option added
|
Please, Can you start or make a new PR from the develop branch? Thank you. |
|
You can just edit the PR and change the destination branch |
|
Sorry, I always forget to change the base branch:( |
|
Thx. No worries. It allowed me to see that I can edit the PR to edit myself the destination branch ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the changes for the
--sensor-width,--interactive&--default_focaloptions as described in issue 918. As noted on that issue I'm reluctant to add the--remoteoption without a Windows machine to test the build on as I'll need to add extra libraries to support the https file fetch.