Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control points to be optimized #2294

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jvanvugt
Copy link

Adds an option to the Control_Point_Parameter struct to enable optimization of control points in BA, defaults to false so behavior is unchanged.

@pmoulon
Copy link
Member

pmoulon commented Feb 16, 2024

@jvanvugt thank you for the pull request.
Do you have any examples to share to show how much your control points changed during the process?

@jvanvugt
Copy link
Author

In my use case, I'm detecting fiducial markers in images and adding them as control points after doing a regular reconstruction. They are triangulated with TriangulateNViewAlgebraic and then I run BA to minimize the geometric error. I'm not sure how much the points still move but it would be the difference between the algebraic and geometric error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants