[SFM] Using rerun logger for Incremental SfM reconstruction #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visualization of the incremental process has never been so easy. By default a rerun window will open and show the status of the reconstruction: - Show cameras frustum - Point Cloud (with corresponding track ids) - Camera Resection statistics (as graph inlier ratio and a_contrario resection threshold) - Number of camera in the scene (see pose_count timeline) You can use it as following: --rerun_logging [WINDOW(default)|FILE|NONE] - WINDOW => will open rerun window and show the reconstruction - FILE => will log to a sfm_data.rrd file the reconstruction - NONE => Disable rerun logging
|
@khshmt Here is a PR that integrate rerun for logging the reconstruction process.
Let me know how it goes for you. Note: We will solve the GitHub CI errors later. |
|
@pmoulon I got a compile error while building on "develop_rerun_logging" due to a missing header file "openMVG/sfm/sfm_data_io_rerun.hpp", Do I miss something?
|
|
@khshmt Should be fixed now, sorry about this. |
|
No problem |
|
It looks good, I will inspect it more and if you have any further requirements for testing tell me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visualization of the incremental process has never been so easy. By default a rerun window will open and show the status of the reconstruction:
inlier_ratioanda_contrarioresection threshold)You can use it as following:
--rerun_logging [WINDOW(default)|FILE|NONE]
sfm_data.rrdfile the reconstruction