Update tracks.hpp #2268
Open
Update tracks.hpp #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All automated check passed ok. Let me double look to this and test it on various scene and come back to you early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think "k" and "feat.second" have the same value in line 135-136 of "tracks.hpp", but they represent different meanings. Reference to the input of "uf_tree.Union()" in line 118, "feat.second" might be the more logical choice for the input of "uf_tree.Find()".
The reason why "k" and "feat.second" have the same value but different meanings can be find in the issue: #2267