-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop KORAL #1359
Open
mdaiter
wants to merge
26
commits into
master
Choose a base branch
from
develop_koral
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop KORAL #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor in order to use track_sample_triangulation in SfM_Data_Structure_Computation_Blind and SfM_Data_Structure_Computation_Robust. - Enable the support of 2 view tracks in SfM_Data_Structure_Computation_Robust (default option still enforce 3 view).
…penMVG-1 into develop_koral_addition
- Use cmake modern way to configure c++11 feature support - Make KORAL parameter configurable options (scale_factor_, scale_levels_, KFAST_threshold_) - avoid the copy of the keypoint and the descriptor in the openmvg describer.
- Fix OpenMP loop for Visual Studio (did not accept unsigned type) - Fix a loop that can be parallelized (remove the openmp parallelization) - Remove a unused variable
- fix linking error on visual studio - fix progress bar status in GPU_Matcher_Regions - fix GPU matcher compilation target to sm_60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pmoulon ,
Was KORAL branch ever merged into master? If not, shouldn't we merge this in? Wouldn't want this code to die. 😉
Best,
Matthew Daiter