Support exporting image mask files #1244

ZihaoTu · 2018-03-01T04:21:50Z

No description provided.

pmoulon · 2018-03-01T04:31:27Z

Thx can you please use this guide: https://github.com/openMVG/openMVG/blob/master/CONTRIBUTING.md
-> Start from the branch develop.

Support exporting image mask files

Added AR image listing

pmoulon · 2018-03-01T04:43:45Z

Please move your commit f86ff1f to another branch.

pmoulon · 2018-03-01T04:39:32Z

src/software/SfM/main_openMVG2openMVS.cpp

+        auto maskFileName = srcImage + ".mask.png";
+        if (stlplus::is_file(maskFileName)) {
+          Image<openMVG::image::RGBColor> maskRGB, maskRGB_ud;
+          ReadImage(maskFileName.c_str(), &maskRGB);


Can we add the same logic as here: https://github.com/openMVG/openMVG/blob/develop/src/software/SfM/main_openMVG2openMVS.cpp#L162

Sorry I just pushed this safety check some days ago.

pmoulon · 2018-03-01T04:40:15Z

src/software/SfM/main_openMVG2openMVS.cpp

@@ -107,11 +107,20 @@ bool exportToOpenMVS(
        ReadImage(srcImage.c_str(), &imageRGB);
        UndistortImage(imageRGB, cam, imageRGB_ud, BLACK);
        WriteImage(image.name.c_str(), imageRGB_ud);
+        // undistort mask and save it
+        auto maskFileName = srcImage + ".mask.png";


const std::string
Since the type is known and will not change I would prefer to use std::string there.

".mask.png" can be saved in a string and reused.
const std::string openmvs_mask_postfix = ".mask.png";

pmoulon · 2018-03-01T04:40:38Z

src/software/SfM/main_openMVG2openMVS.cpp

@@ -107,11 +107,20 @@ bool exportToOpenMVS(
        ReadImage(srcImage.c_str(), &imageRGB);
        UndistortImage(imageRGB, cam, imageRGB_ud, BLACK);
        WriteImage(image.name.c_str(), imageRGB_ud);
+        // undistort mask and save it
+        auto maskFileName = srcImage + ".mask.png";
+        if (stlplus::is_file(maskFileName)) {


OpenMVG is using braces on new lines.

{ }

pmoulon · 2018-03-01T04:42:35Z

src/software/SfM/main_openMVG2openMVS.cpp

+          Image<openMVG::image::RGBColor> maskRGB, maskRGB_ud;
+          ReadImage(maskFileName.c_str(), &maskRGB);
+          UndistortImage(maskRGB, cam, maskRGB_ud, BLACK);
+          WriteImage((image.name + ".mask.png").c_str(), maskRGB_ud);


use the defined openmvs_mask_postfix

pmoulon · 2018-03-01T04:42:45Z

src/software/SfM/main_openMVG2openMVS.cpp

      }
      else
      {
        // just copy image
        stlplus::file_copy(srcImage, image.name);
+        stlplus::file_copy(srcImage + ".mask.png", image.name + ".mask.png");


Use the defined openmvs_mask_postfix

Export SfM cameras in IncrementalSfM

pmoulon · 2018-03-01T07:25:05Z

src/software/SfM/main_IncrementalSfM.cpp

@@ -248,6 +248,10 @@ int main(int argc, char **argv)
      stlplus::create_filespec(sOutDir, "cloud_and_poses", ".ply"),
      ESfM_Data(ALL));

+    Save(sfmEngine.Get_SfM_Data(),


Do you know that you can call the binary ConvertSfMData with -i SOMETHIG.bin -o SOMETHING_ELSE.json for doing this?

pmoulon · 2018-03-01T07:25:12Z

@ZihaoTu If you want make a PR, please push one commit to the branch else I will have to cherry-pick to keep only the feature

* Improve mse and rmse * Add some checks about camera type * Only support shared model

* Add new class sfm_data_PBA ---- pba_interface * remove .vs

Merge to oppen

export sfm_data_all.json instead of sfm_data.bin

…t behavior

Code formatting. Changed confusing variable names. Keep origin defaul…

Added select sfm and mask features for merging two sfm projects

Don't select initial pair by hand. Fix MaskFeatures bug

Fix mask features bug

Fix wrongly used command line parameter when using pba

Support different focal length

…_imagelisting support multi camera models

Match point without featmap

…oints provide_track_to_compute_3d_points

add sort_and_clean binaray to remove invalid view of sfm_data file

fix_bug

Added undistort software

Add TransformSfMData utility

Fix mirrored camera matrix in TransformSfMData

fix pose idx error if there are some missing extrinsics;

fix bug

…uctureFromKnowPoses Add option to main compute structure from know poses

update build.md

fix_bug

update BUILD.md

Support exporting image mask files

c04ae83

pmoulon changed the base branch from master to develop March 1, 2018 04:30

pmoulon changed the base branch from develop to master March 1, 2018 04:31

chubei-oppen and others added 3 commits March 1, 2018 12:35

Merge pull request #1 from oppenfuture/oppen

5d87412

Support exporting image mask files

Added AR image listing

f86ff1f

Merge pull request #2 from oppenfuture/oppen

36acc61

Added AR image listing

pmoulon requested changes Mar 1, 2018

View reviewed changes

chubei-oppen and others added 2 commits March 1, 2018 13:27

Export SfM cameras in IncrementalSfM

fe55c24

Merge pull request #3 from oppenfuture/oppen

8d02e24

Export SfM cameras in IncrementalSfM

pmoulon reviewed Mar 1, 2018

View reviewed changes

DSaurus and others added 17 commits July 23, 2018 15:28

Add pba support(-p to use)

d71f7b9

Add camera model for pba

2635652

* Improve mse and rmse * Add some checks about camera type * Only support shared model

* Option add -A acransac times and -e use_angle_error

cff3864

* Add new class sfm_data_PBA ---- pba_interface * remove .vs

Merge pull request #6 from DSaurus/master

f7c33be

Merge to oppen

export sfm_data_all.json instead of sfm_data.bin

48f0d88

Merge pull request #7 from oppenfuture/sfmExport

2ec9ae3

export sfm_data_all.json instead of sfm_data.bin

Added undistort software

58bc09b

Code formatting. Changed confusing variable names. Keep origin defaul…

c4b5ce3

…t behavior

Merge pull request #9 from oppenfuture/fix

49bf745

Code formatting. Changed confusing variable names. Keep origin defaul…

Added select sfm and mask features for merging two sfm projects

2b31fe6

Merge pull request #10 from oppenfuture/select

00a26b7

Added select sfm and mask features for merging two sfm projects

Don't select initial pair by hand. Fix MaskFeatures bug

508e335

Merge pull request #11 from oppenfuture/fix

81a0660

Don't select initial pair by hand. Fix MaskFeatures bug

Fix mask features bug

3a3049a

Merge pull request #12 from oppenfuture/fix

4622e07

Fix mask features bug

Fix wrongly used command line parameter when using pba

1643bc5

Merge pull request #13 from oppenfuture/pba

2c9bc1c

Fix wrongly used command line parameter when using pba

chubei-oppen and others added 24 commits November 18, 2019 18:33

Merge pull request #42 from shauidu/support_different_focal_length

73c611c

Support different focal length

matchpoint without featmap

26d2d03

remove unused code

2aaaaaa

support multi camera models

491464a

Merge pull request #45 from oppenfuture/support_multi_camera_model_in…

43aa9ad

…_imagelisting support multi camera models

Merge pull request #44 from shauidu/matchPoint_without_featmap

71cd99b

Match point without featmap

provide_track_to_compute_3d_points

fcece87

Merge pull request #46 from oppenfuture/provide_track_to_compute_3d_p…

fc93adb

…oints provide_track_to_compute_3d_points

fix_bug

f5677bb

add sort_and_clean binaray to remove invalid view of sfm_data file

9f0aad0

Merge pull request #48 from oppenfuture/sort_and_clean

20a4f90

add sort_and_clean binaray to remove invalid view of sfm_data file

Merge pull request #47 from oppenfuture/fix_bug

4848dfe

fix_bug

Add TransformSfMData utility

0c1d91f

Merge pull request #8 from oppenfuture/undistort

7ab73eb

Added undistort software

Rename vec3 to pt3. Fix rotation conversion.

5be5577

Merge pull request #50 from oppenfuture/transform

baf2c6d

Add TransformSfMData utility

Fix mirrored camera matrix in TransformSfMData

d47e3a2

Merge pull request #51 from oppenfuture/transform

f800ef4

Fix mirrored camera matrix in TransformSfMData

fix compile error if not build with opencv;

7a77a0a

fix pose idx error if there are some missing extrinsics;

update conan opencv dependency

1d2d674

add option to main_ComputeStructureFronKnownPoses

55cfd40

Merge pull request #52 from oppenfuture/fix_bug

8b9bc3b

fix bug

Merge pull request #53 from oppenfuture/add_option_to_main_ComputeStr…

377cb4e

…uctureFromKnowPoses Add option to main compute structure from know poses

update build.md

6891816

shauidu force-pushed the oppen branch from 5698335 to 377cb4e Compare May 10, 2021 05:26

shauidu and others added 5 commits May 10, 2021 13:28

fix_bug

e4b820d

Merge pull request #54 from oppenfuture/update_build.md

c68474d

update build.md

Merge pull request #55 from oppenfuture/fix_bug

ec1f0d0

fix_bug

update BUILD.md

0a0b567

Merge pull request #56 from oppenfuture/update_build_md

29788d9

update BUILD.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support exporting image mask files #1244

Support exporting image mask files #1244

ZihaoTu commented Mar 1, 2018

pmoulon commented Mar 1, 2018

pmoulon commented Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon Mar 1, 2018

pmoulon commented Mar 1, 2018 •

edited

Support exporting image mask files #1244

Are you sure you want to change the base?

Support exporting image mask files #1244

Conversation

ZihaoTu commented Mar 1, 2018

pmoulon commented Mar 1, 2018

pmoulon commented Mar 1, 2018

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon Mar 1, 2018

Choose a reason for hiding this comment

pmoulon commented Mar 1, 2018 • edited

pmoulon commented Mar 1, 2018 •

edited