Fix very broken Meson build #1275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some required sources were just missing. Other conditional sources hadn't been made conditional.
|
Thanks for the patch! The Meson build is still experimental and isn't part of our CI infrastructure yet, so it easily gets out of date. After the 16.0 release I want to resume working on it and I'll integrate your patch then. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some required sources were just missing. Other conditional sources hadn't been made conditional.
I'm really glad you've started using Meson and I understand it's a work in progress but you might want to test it once in a while. 馃槢 I don't think it's worked since at least April.