Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display default Language dropdown #2045

Closed
wants to merge 1 commit into from

Conversation

Omar-Nabil
Copy link
Contributor

@Omar-Nabil Omar-Nabil commented Mar 21, 2024

Description

i added all languages allowed in mifos app to the dropdown list

Related issues and discussion

#2039

Screenshots, if any

2024-03-20.22-51-32.mp4

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@PC-11-00 PC-11-00 self-requested a review March 21, 2024 02:47
Copy link
Collaborator

@PC-11-00 PC-11-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@alberto-art3ch alberto-art3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please instead of use hardcoded languages we can read those from the environment object

@Omar-Nabil
Copy link
Contributor Author

Omar-Nabil commented Mar 23, 2024

@alberto-art3ch i did it you can review the code now

2024-03-23.06-54-47.mp4

Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@Omar-Nabil Omar-Nabil closed this by deleting the head repository May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants