fix(pubsub): Fixed DSR not coming back from error state after communication resumes #6280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation resumes Reader which MessageReceiveTimeout elapsed was ignored when parsing incoming messages, so it couldn't get back to 'operational' state even after communication resumed.
MichalTyndel
force-pushed
the
MT_FIX_DSRERROR
branch
from
c7f4b1a
to
2249dd1
Compare
|
Updated pubsub test (wrong timeout). Removed part of it, where the state toggles between error and operational. Now that it actually toggles checking expected state in callback will not work this way anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader which MessgaeReceiveTimeout elapsed was ignored when parsing incoming messages, so it couldn't get back to 'operational' state even after communication resumed.