Porting to ARM Ertec with eCos #6113
Conversation
|
|
| @@ -134,8 +135,19 @@ def writeh(line): | |||
|
|
|||
| def writec(line): | |||
| print(unicode(line), end='\n', file=outfilec) | |||
|
|
|||
| def parentNodeString(node,L): | |||
There was a problem hiding this comment.
This can be simplified
def parentNodeString(node,L):
if node is None or node.parent is None:
return ""
return str(parentNodeString(node.parent,L)) + "_" + str(node.displayName).upper()
arch/eCos/ua_clock.c
Outdated
| @@ -24,9 +25,12 @@ UA_Int64 UA_DateTime_localTimeUtcOffset(void){ | |||
| return (UA_Int64) (difftime(rawtime, gmt) * UA_DATETIME_SEC); | |||
| } | |||
|
|
|||
| #define TICKS_TO_MS(Ticks) \ | |||
There was a problem hiding this comment.
This file only exists in the 1.3 branch and before.
We refactored quite a lot of the architecture integration API.
We will bring this back when we can.
But we didn't have the tooling to compile against eCos during the time when the API was revised.
| @@ -50,6 +50,7 @@ connection_releaserecvbuffer(UA_Connection *connection, | |||
| UA_ByteString_clear(buf); | |||
| } | |||
|
|
|||
| #ifdef poll | |||
There was a problem hiding this comment.
Isn't it possible to disable the poll bits of the function by ifdef's, so that only 3 + 4 lines are disabled instead of completely duplicating the function?
| static UA_INLINE UA_FORMAT(3,4) void | ||
| UA_LOG_TRACE(const UA_Logger *logger, UA_LogCategory category, const char *msg, ...) { | ||
| static UA_INLINE UA_FORMAT(4,5) void | ||
| UA_LOG_TRACE2(const UA_Logger *logger, UA_LogCategory category, unsigned int line, const char *msg, ...) { |
There was a problem hiding this comment.
When adding an argument here, you should probably also add (void) line; in case UA_LOGLEVEL > 100. Ditto for the functions below.
Porting to eCos with GCC C89 compiler
Generate symbolic defines so that the application does not have to use magic numbers