Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in nodemanagement to fix problem with structures which are not #5906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ml-bb
Copy link

@ml-bb ml-bb commented Jul 28, 2023

created with Variable Type BaseDataVariableType.

If creating a structure with BaseDataVariableType as type definition, the attribute read before has no value. Because of this writeAttribute() is not called.

If creating a structure with another variable type as type definition, the attribute has a value. Strange it tells, that it is an extension object and not a structure anymore.
Afterwards writeAttribute() in the NodeSet changes the structre to an extension object.

This leads to the problem that we can not describe and handle the node properly after construction.

Here we fix the problem by not overwriting the attribute if it of type extension object.

created with Variable Type BaseDataVariableType.

If creating a structure with BaseDataVariableType as type definition,
the attribute read before has no value. Because of this writeAttribute()
is not called.

If creating a structure with another variable type as type definition,
the attribute has a value. Strange it tells, that it is an extension
object and not a structure anymore.
Afterwards writeAttribute() in the NodeSet changes the structre to an
extension object.

This leads to the problem that we can not describe and handle the node
properly after construction.

Here we fix the problem by not overwriting the attribute if it of type
extension object.
@ml-bb
Copy link
Author

ml-bb commented Jul 28, 2023

Since we are not completely confident that this really solves the problem, we would really be thankful to have your feedback about this.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants