Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view usage/verification #7

Open
gfudenberg opened this issue Nov 17, 2022 · 5 comments
Open

view usage/verification #7

gfudenberg opened this issue Nov 17, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@gfudenberg
Copy link
Member

gfudenberg commented Nov 17, 2022

would it make sense to verify view/cooler compatibility before launching all rules?

also, did we decide that views should be saved w/o headers?

it seems that many rules don't support views-- should that be a future upgrade?

@gfudenberg gfudenberg added the enhancement New feature or request label Nov 17, 2022
@gfudenberg gfudenberg changed the title view verification view usage/verification Nov 18, 2022
@Phlya
Copy link
Member

Phlya commented Nov 22, 2022

Re verification, that's a good idea.

Headers - I don't know... Good question.

All rules support a view (where the underlying command supports it, so not chromosight or mustache), just define it once at the top of the config and it will be applied everywhere.

@Phlya
Copy link
Member

Phlya commented Nov 22, 2022

Verification is done! Just in the main code in the Snakefile for local coolers, and immediately in the download rule for remote coolers.

@Phlya
Copy link
Member

Phlya commented Nov 22, 2022

In general there are a lot more checks that con be done on all inputs, we can just start a separate issue with a checklist for that.

@Phlya
Copy link
Member

Phlya commented Feb 9, 2023

FYI actually for now I disabled this because for some reason it was erroring on valid views... Need to figure it out at some point.
Actually, seems fine...

@Phlya
Copy link
Member

Phlya commented Jun 15, 2023

After all I keep getting errors for view that are totally valid, no idea why....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants