Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export chai so that it doesn't lose its typing #2652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allejo
Copy link

@allejo allejo commented Mar 29, 2023

What I did

  1. Change the way that Chai's utilities are re-exported via this package.

The current way that chai is being exported causes it to lose its typing information and gets inferred as any, which causes a number of problems.

image

Instead of manually declaring the elements that are exported from Chai and setting their types, just export directly from the Chai module and that resolves typing issue.

image

This shouldn't have any functional behavior changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: 9e9d634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants