Implement downloads from json file #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft#1366) Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
This should have the effect of disabling this on macOS which hopefully fixes the Python2 hang. Related: microsoft#1255
Thomas1664
commented
Apr 2, 2024
src/vcpkg/download.cpp
Outdated
|
|
||
| r.optional_object_field(obj, "patches", result.patches, Json::IdentifierArrayDeserializer::instance); | ||
|
|
||
| result.urls.emplace_back(fmt::format("https://api.{}/repos/{}/tarball/{}", gh_gost, repo, ref)); |
There was a problem hiding this comment.
I decided to build the URL here in order to unify and simplify DownloadedFile for all downloading methods.
| Optional<type> visit_object(Json::Reader& r, const Json::Object& obj) const override | ||
| { | ||
| DownloadedFile result; | ||
| if (auto value = obj.get("github")) |
There was a problem hiding this comment.
Using this instead of the id as keys simplifies parsing a lot.
Hopefully fixes: microsoft/vcpkg#37842 Special thanks to @TrueBrain for figuring out the actual problem in microsoft#1378 Co-authored-by: Patric Stout <truebrain@openttd.org>
* should be forward slashes * add script to check for unused messages * add messages check to pr workflow * error if unused messages * dont print every message every time * remove bogus comment * remove bogus comment * remove bogus comment (again) * Remove timer; add word boundry to regex;merge format and very messages job in pr.yaml * Use JSON files instead of REGEX to declare messages * pass artifact messages as argument * filter out empty from unused messages * filter out empty from unused messages * infer path from PSScriptRoot; reuse configure in format job * remove unused messages * add new line at the end of ps script * remove unused messages * try something * add messages.json again --------- Co-authored-by: Javier Matos <javiermatos@Javiers-Laptop.local> Co-authored-by: Javier Matos <javiermatos@Javiers-Laptop.lan>
Problems were: - the only test in e2e_ports folder, everything else in e2e-ports - tests modify files under $VCPKG_ROOT - Divided in two files where one enough - Tests fail if package is already in binary cache
…ft#1367) In microsoft/vcpkg#37563 (comment) we have an example of versions which meet the semantic versioning format but don't sort like semantic versions, so the message: ```console PS D:\vcpkg> .\vcpkg.exe x-add-version sqlite-modern-cpp Use the version scheme "version" rather than "version-string" in port "sqlite-modern-cpp". Use --skip-version-format-check to disable this check. ``` is too strong. We need to explain to the user that they should only do that if the versions actually are intended to sort that way.
* Eliminate PurgeDecompressFailure. PurgeDecompressFailure causes the files backend for binary caching to delete the zip file if it fails to decompress. The install command set this to false due to a race consideration: it's possible that a partially uploaded zip is observed when the files backend is pointed to a network share, and deleting the file because we failed to decompress it just stomps on another builder sharing that same binary cache. It seems incorrect that this reasoning would not apply to any other commands, but most of the other commands said PurgeDecompressFailure::Yes. This change removes the option entirely in favor of the 'No' behavior. * Do not redundantly set Editable or Use Head to false in manifest mode. These are already implied by the blockers on line 1075 and 1080. * While reviewing changes to microsoft#1339 , I observed that it was strange that the abi hash depends on whether download_only is selected. After discussion with @ras0219-msft , he agreed that the ABI hash shouldn't be affected by this setting. However, given that in download mode, we intentionally build things which do not have all their dependencies present, it would not be safe to attempt to cache or otherwise install anything in that condition. This change removes download_only from the ABI calculation, and changes installation to only attempt to install built bits whose dependencies are all satisfied.
…crosoft#1397) * Add support for VS 2022 using VS170COMNTOOLS environment variable * keep existing pattern Co-authored-by: Billy O'Neal <bion@microsoft.com> --------- Co-authored-by: Javier Matos <javiermatos@Javiers-Laptop.local> Co-authored-by: Billy O'Neal <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-vcpkg/meta#6
See the linked issue for more information.
Benefits
--only-downloadsChanges in behavior
Applying patches
All patches are now applied within a single
gitcommand. Because the output fromstdoutis always empty, all logs are saved into a single file.