-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use versions catalog for convention plugins #1
Use versions catalog for convention plugins #1
Conversation
105910b
to
eef9c89
Compare
Thank you for your contribution @piloudu! We can make |
eef9c89
to
ab50724
Compare
Hi @Morfly! Sure, I've just made those changes. Could you check again if everything looks good for you?
I've applied the same approach to the // Using alias as follows...
plugins {
alias(libs.plugins.sample)
}
// ... is the same as applying the plugin with an specific version
plugins {
id(libs.plugins.sample.get().pluginId) version libs.plugins.sample.get().version apply true
} Taking this into consideration, any |
@piloudu thank you for the update. We can still use these plugins as |
fdd6998
to
66c6245
Compare
66c6245
to
cfa956d
Compare
That's a great point! I didn't know that I've performed those changes and I'm up to new suggestions if needed |
cfa956d
to
0832af5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the updates to the PR @piloudu. all looks good to me!
Description
This technical improvement PR aims at providing type-safe plugin references by registering the convention plugins in the
libs.versions.catalog
fileSome advantages: