Add metrics for the BEAM-VM #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsloughter @ferd following the comments on open-telemetry/opentelemetry-erlang-contrib#299, I've prepared a suggestion for the BEAM-VM metrics. I think it makes sense to agree on a specification before continuing with the implementation. |
ferd
reviewed
Apr 17, 2024
| | `nif` | Time spent in NIFs. Without extra states this time is part of the emulator state. |  | | ||
| | `send` | Time spent sending messages (processes only). Without extra states this time is part of the emulator state. |  | | ||
| | `timers` | Time spent managing timers. Without extra states this time is part of the other state. |  | | ||
| <!-- endsemconv --> |
There was a problem hiding this comment.
We should probably repeat the microstate accounting caveat that seems to only exist in the declaration yaml and code for this section?
| | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | | ||
| |---|---|---|---|---|---| | ||
| | `beam.memory.allocators.alloc` | string | The allocation type. | `sys_alloc` | `Recommended` |  | | ||
| | `beam.memory.allocators.instance_no` | int | The logical instance number [0..n] | `1` | `Recommended` |  | |
There was a problem hiding this comment.
I feel like using beam.memory.allocators.instance here is not losing any descriptiveness but also lines up with what the OTP docs would provide?
|
@tsloughter would love a review on this. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add metrics for the BEAM-VM
Merge requirement checklist
[chore]