Fix bug where Pods get stuck Terminating because of SDK Injection modifications #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyKlop
force-pushed
the
bugfix/ignore-pod-deletion
branch
from
c9f2b6c
to
34db087
Compare
WesleyKlop
force-pushed
the
bugfix/ignore-pod-deletion
branch
from
34db087
to
bd4831c
Compare
|
@WesleyKlop checking in here, would you be able to add a unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I think this solves #1417 by not adding/changing instrumentation on Pods that have a Deletion timestamp. I don't know for certain if this is the most clean solution but I think it should work!
I'm missing tests but I don't know how to best test this.