New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove opentelemetry-proto in .gitsubmodule #5267
Open
YHM404
wants to merge
3
commits into
open-telemetry:main
Choose a base branch
from
YHM404:hm/rm-useless-submodule
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YHM404
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
April 26, 2024 04:14
|
pellared
added
the
blocked:CLA
Waiting on CLA to be signed before progress can be made
label
Apr 26, 2024
MrAlias
added
the
response needed
Waiting on user input before progress can be made
label
May 2, 2024
@YHM404 bump |
YHM404
force-pushed
the
hm/rm-useless-submodule
branch
from
May 21, 2024 14:45
7e5deed
to
162bb40
Compare
Hi, I already signed EasyCLA. and I recorrect the referenced PR. |
MrAlias
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
blocked:CLA
Waiting on CLA to be signed before progress can be made
response needed
Waiting on user input before progress can be made
labels
May 21, 2024
MrAlias
approved these changes
May 21, 2024
hanyuancheung
approved these changes
May 22, 2024
dmathieu
approved these changes
May 22, 2024
pellared
approved these changes
May 22, 2024
pellared
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not simply removing the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-proto was removed in #1713