add demo for otel-collector for metrics #2796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
|
|
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
force-pushed
the
otel-controller-demo-for-metrics
branch
from
561f58c
to
22c928f
Compare
bogdandrutu
reviewed
Apr 19, 2022
| ) | ||
|
|
||
| var ( | ||
| meterProvider metric.MeterProvider |
There was a problem hiding this comment.
I have seen the same example in the collector repo. Should we avoid using "globals" and simply return the provider as the initProvider() return value, and use that instance to create a meter and stop?
There was a problem hiding this comment.
ok, I will fix like that.
Codecov Report
@@ Coverage Diff @@
## main #2796 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 179 179
Lines 11818 11818
=====================================
+ Hits 8951 8953 +2
+ Misses 2634 2632 -2
Partials 233 233
|
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
6 tasks
|
Closing as this PR is outdated and the issue was solved by #5283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2161
Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com