Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otel-collector example does not use metrics #2161

Closed
mx-psi opened this issue Aug 4, 2021 · 6 comments
Closed

otel-collector example does not use metrics #2161

mx-psi opened this issue Aug 4, 2021 · 6 comments
Assignees
@fatsheep9146
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information enhancement New feature or request help wanted Extra attention is needed pkg:example Related to an example

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 4, 2021 •
edited

Description

The example/otel-collector example mentions metrics on its README but it does not have any metrics export code since #1990.

Expected behavior

The example would either document how to use metrics or it would remove any mention of metrics from its description.
@mx-psi mx-psi added the bug Something isn't working label Aug 4, 2021
@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information enhancement New feature or request pkg:example Related to an example release:after-1.0 and removed bug Something isn't working labels Aug 5, 2021
@Aneurysm9
Copy link
Member

It looks like the metrics part of the example was removed when we were splitting up the OTLP exporter and never added back. We should probably create a separate example for metrics as we have included this example in the stable version set and cannot take a metrics dependency there until metrics are stable.

@MrAlias MrAlias added the help wanted Extra attention is needed label Dec 6, 2021
@fatsheep9146
Copy link
Contributor

I'm new on OpenTelemetry, and when I search for demo examples, I found this issue. If this issue still need help, I've love to help with this. Is this ok for you? @Aneurysm9 @MrAlias

@Aneurysm9
Copy link
Member

That would be great, @fatsheep9146. I'll assign this issue to you.

@fatsheep9146
Copy link
Contributor

I've already tested the demo code for metrics otel-collector locally, but I'm not sure how to write this doc is the best.

  1. Modify this existing 'otel-collector' example, complement with metric part
  2. Add a new folder which name is 'otel-collector-for-metric' and put the code right there.

Which one do you suggest? @Aneurysm9

@fatsheep9146 fatsheep9146 mentioned this issue Apr 19, 2022
Closed
@fatsheep9146
Copy link
Contributor

I have already make a seperate demo for otel-colletor and metric data. @mx-psi @Aneurysm9 @MrAlias

@pellared
Copy link
Member

Solved by #5283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information enhancement New feature or request help wanted Extra attention is needed pkg:example Related to an example
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add demo for otel-collector for metrics fatsheep9146/opentelemetry-go
5 participants
@Aneurysm9 @pellared @mx-psi @MrAlias @fatsheep9146