Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct default temporality for streams based on the instrument kind #713

Merged
merged 3 commits into from Mar 18, 2024

Conversation

tsloughter
Copy link
Member

Ignore that the changelog is wrong in this PR, when it gets merged with main after #711 is merged I'll fix it up and update this PR.

Once this is in I'll publish a patch release of the experimental SDK.

@tsloughter tsloughter requested a review from a team as a code owner March 17, 2024 21:05
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (233d283) to head (aaece44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files          61       61           
  Lines        1935     1935           
=======================================
  Hits         1415     1415           
  Misses        520      520           
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.44% <ø> (ø)
exporter 67.47% <ø> (ø)
sdk 78.69% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsloughter tsloughter merged commit e8c2b2a into open-telemetry:main Mar 18, 2024
15 checks passed
@tsloughter tsloughter deleted the fix-default-temporality branch March 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants