New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library to support Telemetry.Metrics as OpenTelemetry metrics #303
base: main
Are you sure you want to change the base?
Conversation
Forgot I needed to make So may just add a warning in the docs that Scope is going to be wrong for all your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
utilities/opentelemetry_telemetry_metrics/lib/otel_telemetry_metrics.ex
Outdated
Show resolved
Hide resolved
require Logger | ||
use GenServer | ||
|
||
@doc """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doc """ | |
@doc """ | |
Starts open telemetry metrics reporter process. | |
Accepts the same options as `GenServer.start_link/2`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last line seems wrong? Or at least confusing. That'd make me think the options
are ones for configuring the GenServer
, stuff like hibernate
, but its the options to be passed to init
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, sorry.
…etrics.ex Co-authored-by: José Valim <jose.valim@gmail.com>
Can I help you guys somehow? Have to submit metrics to Google Metrics for alerting and, since our metrics are not mission critical, we can try to pilot this PR in production. |
@AndrewDryga yes, definitely! Are you on slack? I hit a bug in metrics that has kept me from having time to spend on docs but could help you on slack to get going. |
Not ready because still using local changes in the deps but wanted to open it up for review while those changes are being merged and released.