Fix memory leak in TlsRandomNumberGenerator() constructor #2660 #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
e6b5f8b
to
c2ce0fb
Compare
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
3 times, most recently
from
cdffe88
to
9ebc698
Compare
ThomsonTan
reviewed
May 8, 2024
| @@ -26,12 +27,17 @@ class TlsRandomNumberGenerator | |||
| TlsRandomNumberGenerator() noexcept | |||
| { | |||
| Seed(); | |||
| platform::AtFork(nullptr, nullptr, OnFork); | |||
| if (!flag.test_and_set()) | |||
There was a problem hiding this comment.
Is it possible to add a test for this?
There was a problem hiding this comment.
Hello, unit test has been added.
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
9ebc698
to
e665d74
Compare
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
be00d4d
to
6b44492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2660
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes