Add support for bzlmod #2608
Draft
Add support for bzlmod #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will probably fail CI with the same issue as #2599 |
keith
force-pushed
the
ks/add-support-for-bzlmod
branch
from
ea5e310
to
8ba900a
Compare
|
ok I pushed an update here that seems to fix it at least with c++17, it depends on bazelbuild/bazel-central-registry#1810 |
keith
force-pushed
the
ks/add-support-for-bzlmod
branch
from
66ae4c3
to
f140acc
Compare
keith
force-pushed
the
ks/add-support-for-bzlmod
branch
from
f140acc
to
f9c9ce9
Compare
|
Hi @keith Could you merge with a recent main to resolve conflicts, Thanks, |
This adds support for bzlmod, which is bazel's new dependency resolution system. Theoretically we could now remove the previous dependency management configuration which required flattening all the dependencies, but I left it here for now for users using old versions of bazel.
keith
force-pushed
the
ks/add-support-for-bzlmod
branch
from
8f4db8d
to
4d070b8
Compare
|
The windows and asan failures here are real. |
marcalff
removed
the
pr:fix-merge-conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for bzlmod, which is bazel's new dependency resolution system.
Theoretically we could now remove the previous dependency management configuration which required flattening all the dependencies, but I left it here for now for users using old versions of bazel.
Fixes: #2334