Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bzlmod support #2334

Open
auzhva opened this issue Sep 27, 2023 · 6 comments · May be fixed by #2608
Open

Add bzlmod support #2334

auzhva opened this issue Sep 27, 2023 · 6 comments · May be fixed by #2608
Labels
enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers

Comments

@auzhva
Copy link

auzhva commented Sep 27, 2023

Since bazel 6.0, bazel added bzlmod dependency management and tracking system. Currently open telemetry is built by Bazel but is not published to the Bazel Central Regestry, which complicates importing open telemetry.

It would be awesome if open telemetry would be packaged to the BCR.

Is your feature request related to a problem?
Opentelemetry imports dependencies with own opentelemetry_cpp_deps, which is not portable to bzlmod.

Describe the solution you'd like
Create MODULE.bazel and publish to the BCR

Describe alternatives you've considered
Continue using existing, but it's... Hard...
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 27, 2023
@esigo
Copy link
Member

esigo commented Oct 9, 2023

@auzhva unfortunately we could not offer any official packaging.

@marcalff
Copy link
Member

While this request makes sense, we (in opentelemetry-cpp) can not provide packaging for every build system.

The best way to address this is to make a contribution to the Bazel Central Registry directly.

@marcalff marcalff added wontfix This will not be worked on enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. wontfix This will not be worked on labels Oct 18, 2023
@github-actions
Copy link

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

@marcalff
Copy link
Member

Added help wanted to advertise.

Do not prepare a PR for opentelemetry-cpp, contribute to https://registry.bazel.build/ instead.

@github-actions GitHub Actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 19, 2023
@keith keith linked a pull request Mar 25, 2024 that will close this issue
Draft
@keith
Copy link
Contributor

keith commented Mar 25, 2024

👋 I submitted a PR for the modern bazel dependency management setup here:

I know there was some discussion above about submitting the config to the BCR (which I will do if this PR is merged), but my PR here is still required to modernize the bazel config in this repo.

We could also theoretically remove the old version of doing things in bazel, since right now there is some duplication, but I am initially leaving it in my PR to not affect users on older versions of bazel. I'm happy to remove it though and direct older bazel users to prior releases of this library instead if you'd prefer!

#2608

@github-actions github-actions bot removed the Stale label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for bzlmod keith/opentelemetry-cpp
4 participants
@keith @auzhva @marcalff @esigo