Add metric producers to meter_provider configuration #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
commented
May 17, 2024
dashpole
commented
May 17, 2024
dashpole
force-pushed
the
metric_producers
branch
from
29c0fa9
to
70f2ef1
Compare
jack-berg
reviewed
May 20, 2024
jack-berg
reviewed
May 21, 2024
jack-berg
reviewed
May 21, 2024
codeboten
reviewed
May 21, 2024
|
/easycla |
dashpole
force-pushed
the
metric_producers
branch
from
b4c085a
to
9fb79e5
Compare
dashpole
commented
May 21, 2024
jack-berg
approved these changes
May 21, 2024
codeboten
approved these changes
May 23, 2024
bogdandrutu
reviewed
May 24, 2024
Comment on lines
+49
to
55
| }, | ||
| "producers": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/$defs/MetricProducer" | ||
| } | ||
| } |
There was a problem hiding this comment.
Why is this needed here if already in the top level MetricReader? If it is required for pull (maybe to control at a granular level) why not for periodic as well?
There was a problem hiding this comment.
Thanks for calling this out @bogdandrutu!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-specification#4015
Metric producers are registered to metric readers, so i've nested it under the periodic and manual readers.
@gouthamve @jack-berg