[confmap] support unmarshaling for embedded structs with and without squashing #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9861 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 356 356
Lines 19169 19170 +1
=======================================
+ Hits 17506 17507 +1
Misses 1335 1335
Partials 328 328 ☔ View full report in Codecov by Sentry. |
dmitryax
reviewed
Mar 27, 2024
|
Added a changelog. |
mx-psi
approved these changes
Apr 2, 2024
|
@atoulme can you fix the merge conflicts? |
atoulme
force-pushed
the
embedded_unmarshaler
branch
from
7c96014
to
1182205
Compare
|
Done. |
dmitryax
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taking a small slice of #9750 to document the behavior of confmap and make sure we can unmarshal embedded structs.