Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] remove deprecated funcs #9836

Merged

Conversation

TylerHelmuth
Copy link
Member

Closes #9482
Closes #9812

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner March 25, 2024 20:37
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (26ee291) to head (5f84065).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9836      +/-   ##
==========================================
- Coverage   91.32%   91.32%   -0.01%     
==========================================
  Files         356      356              
  Lines       19170    19168       -2     
==========================================
- Hits        17507    17505       -2     
  Misses       1335     1335              
  Partials      328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member Author

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit about the comment

config/configgrpc/configgrpc.go Show resolved Hide resolved
@mx-psi mx-psi merged commit 4f56509 into open-telemetry:main Apr 3, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 3, 2024
@TylerHelmuth TylerHelmuth deleted the configgrpc-remove-deprecated-funcs branch April 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configgrpc] Update public methods to accept context.Context [configrpc] Remove SanitizedEndpoint?
2 participants