[chore] typo: connect -> connection #9802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9802 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 353 353
Lines 18712 18712
=======================================
Hits 17036 17036
Misses 1348 1348
Partials 328 328 ☔ View full report in Codecov by Sentry. |
| @@ -58,7 +58,7 @@ func (tt *TransportType) UnmarshalText(in []byte) error { | |||
| // DialerConfig contains options for connecting to an address. | |||
| type DialerConfig struct { | |||
| // Timeout is the maximum amount of time a dial will wait for | |||
| // a connect to complete. The default is no timeout. | |||
| // a connection to complete. The default is no timeout. | |||
There was a problem hiding this comment.
This comment is lifted from https://pkg.go.dev/net#Dialer so I'm not sure we need to change it.
|
Alright, no need for this change, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.