New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confignet] Mark as stable #9801
[confignet] Mark as stable #9801
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9801 +/- ##
==========================================
+ Coverage 91.02% 91.04% +0.01%
==========================================
Files 353 353
Lines 18704 18712 +8
==========================================
+ Hits 17026 17036 +10
+ Misses 1350 1348 -2
Partials 328 328 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have reviewed the code and the test coverage, everything looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking how to reduce code duplication between TCPAddrConfig
and AddrConfig
, but cannot see a clean simple way. Go isn't very flexible sometimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By stabilizing this, we commit to two things from confmap:
- Supporting
mapstructure
YAML tags. I am fine with that, I don't think there is much of a point on changing it, but I know there has been some discussion about this (@atoulme may have more details?). Is this resolved? - Supporting
UnmarshalText
on config unmarshaling. This is a standard library interface, so I think it is a pretty safe assumption.
We also commit to one thing from component
:
AddrConfig
implementscomponent.ConfigValidator
:func (na *AddrConfig) Validate() error {
For the implicit dependency on component
, I don't really get why we are adding Validate()
: the UnmarshalText
method from the transport should already do validation at unmarshaling time. Shouldn't that be enough? If we can remove that method, we eliminate one implicit dependency.
@mx-psi I believe |
@mx-psi based on your comments it sounds like we have sufficient dependencies on |
Or at least I think if we merge this, we should have a way to validate that we are not changing these assumptions |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Will reopen once |
Description:
Mark
confignet
as StableLink to tracking Issue:
Closes #9045