Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtls] Removed deprecated structs #9786

Merged
merged 11 commits into from Mar 27, 2024

Conversation

TylerHelmuth
Copy link
Member

Description:
Removed deprecated structs

Link to tracking Issue:
Related to #9428
Related to #9474
Closes #9548

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner March 18, 2024 20:29
@TylerHelmuth
Copy link
Member Author

@TylerHelmuth TylerHelmuth marked this pull request as draft March 18, 2024 20:31
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (f237238) to head (151f8e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9786   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         353      353           
  Lines       18746    18746           
=======================================
  Hits        17085    17085           
  Misses       1333     1333           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth marked this pull request as ready for review March 19, 2024 12:26
@mx-psi
Copy link
Member

mx-psi commented Mar 20, 2024

Looks like there are a few fixes missing on contrib:

# github.com/open-telemetry/opentelemetry-collector-contrib/exporter/opencensusexporter [github.com/open-telemetry/opentelemetry-collector-contrib/exporter/opencensusexporter.test]
Error: ./config_test.go:61:7: unknown field TLSSetting in struct literal of type configtls.ClientConfig
Error: ./factory_test.go:127:7: unknown field TLSSetting in struct literal of type configtls.ClientConfig
Error: ./factory_test.go:141:7: unknown field TLSSetting in struct literal of type configtls.ClientConfig
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver [github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver.test]
Error: ./config_test.go:166:4: unknown field TLSSetting in struct literal of type configtls.ClientConfig

@TylerHelmuth
Copy link
Member Author

@mx-psi those errors are happening because ClientConfig and ServerConfig use mapstructure:",squash" and the type was changed to Config from TLSSetting - this is a new breaking change being introduced in this PR as part of the removal. I've created separate changelog entries to help api users see both breaking changes from this PR. Once this PR is merged I'll update Contrib to use Config instead of TLSSetting in the tests.

@mx-psi
Copy link
Member

mx-psi commented Mar 26, 2024

Thanks for explaining, you are right that this can't be fixed in contrib before merging this. I will wait to merge this until we are done with the contrib release

@TylerHelmuth TylerHelmuth added the ready-to-merge Code review completed; ready to merge by maintainers label Mar 26, 2024
@mx-psi mx-psi merged commit 1038b67 into open-telemetry:main Mar 27, 2024
36 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@TylerHelmuth TylerHelmuth deleted the configtls-remove-deprecated branch March 27, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confighttp/configgrps] Rename the fields of types that were renamed in configtls
3 participants