Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver] Remove deprecated ScraperControllerSettings and NewDefaultScraperControllerSettings #9783

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 17, 2024

Description:
Remove deprecated ScraperControllerSettings and NewDefaultScraperControllerSettings

Link to tracking Issue:
#6767

@atoulme atoulme requested a review from a team as a code owner March 17, 2024 01:19
@atoulme atoulme requested a review from djaglowski March 17, 2024 01:19
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (7f13812) to head (598261d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9783      +/-   ##
==========================================
+ Coverage   90.99%   91.02%   +0.02%     
==========================================
  Files         353      353              
  Lines       18706    18704       -2     
==========================================
+ Hits        17022    17025       +3     
+ Misses       1356     1352       -4     
+ Partials      328      327       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member

@dmitryax dmitryax merged commit ef4fb3a into open-telemetry:main Mar 20, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 20, 2024
@atoulme atoulme deleted the remove_deprecated_scrapercontrollersettings branch March 20, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants