Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][status] Remove deprecated functions ReportComponentStatus and ReportComponentOkIfStarting #9782

Merged
merged 1 commit into from Mar 19, 2024
Merged

[chore][status] Remove deprecated functions ReportComponentStatus and ReportComponentOkIfStarting #9782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions service/internal/status/status.go
View file
Open in desktop
Expand Up @@ -121,17 +121,6 @@ func (r *Reporter) Ready() {
r.ready = true
}

// ReportComponentStatus reports status for the given InstanceID
// Deprecated: [v0.92.0] This function will be removed in a future release.
// Use ReportStatus instead.
func (r *Reporter) ReportComponentStatus(
id *component.InstanceID,
ev *component.StatusEvent,
) error {
r.ReportStatus(id, ev)
return nil
}

// ReportStatus reports status for the given InstanceID
func (r *Reporter) ReportStatus(
id *component.InstanceID,
Expand All @@ -148,14 +137,6 @@ func (r *Reporter) ReportStatus(
}
}

// ReportComponentOkIfStarting reports StatusOK if the component's current status is Starting
// Deprecated: [v0.92.0] This function will be removed in a future release.
// Use ReportOKIfStarting instead.
func (r *Reporter) ReportComponentOKIfStarting(id *component.InstanceID) error {
r.ReportOKIfStarting(id)
return nil
}

func (r *Reporter) ReportOKIfStarting(id *component.InstanceID) {
r.mu.Lock()
defer r.mu.Unlock()
Expand Down