Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Remove deprecated error ErrNilNextConsumer #9779

Merged
merged 2 commits into from Mar 20, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 17, 2024

Description:
Remove deprecated error ErrNilNextConsumer

Link to tracking Issue:
Fixes #9322

@atoulme atoulme requested a review from a team as a code owner March 17, 2024 00:11
@atoulme atoulme requested a review from jpkrohling March 17, 2024 00:11
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (7f13812) to head (524c650).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9779   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         353      353           
  Lines       18706    18706           
=======================================
  Hits        17022    17022           
  Misses       1356     1356           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 17, 2024

dmitryax pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 19, 2024
**Description:**
Remove explicit checks in all receivers to check if the next consumer is
nil.
The nil check is now done by the pipeline builder.

This is a follow up of
open-telemetry/opentelemetry-collector#9322.

This PR blocks
open-telemetry/opentelemetry-collector#9779.
@dmitryax dmitryax merged commit 4df2af2 into open-telemetry:main Mar 20, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 20, 2024
@atoulme atoulme deleted the remove_deprecated_err branch March 20, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component] component.go - review ErrNilNextConsumer
3 participants