Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[chore] Refactor mdatagen unmarshaling to use less custom Unmarshalers" #9773

Merged
merged 1 commit into from Mar 15, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 15, 2024

Reverts #9760

Trying to make contrib happy. We will be back with a unit test covering contrib's usage of mdatagen.

@atoulme atoulme requested a review from a team as a code owner March 15, 2024 17:11
@atoulme atoulme requested a review from djaglowski March 15, 2024 17:11
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.98%. Comparing base (8990be3) to head (28ece75).

Files Patch % Lines
cmd/mdatagen/metricdata.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9773      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         353      353              
  Lines       18636    18648      +12     
==========================================
+ Hits        16958    16967       +9     
- Misses       1352     1354       +2     
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax merged commit 3b5aee0 into main Mar 15, 2024
31 of 46 checks passed
@dmitryax dmitryax deleted the revert-9760-refactor_mdatagen_unmarshal branch March 15, 2024 17:29
@github-actions github-actions bot added this to the next release milestone Mar 15, 2024
@dmitryax
Copy link
Member

We need to add the failing use case to https://github.com/open-telemetry/opentelemetry-collector/tree/main/cmd/mdatagen/internal/samplereceiver before trying to bring this back.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 15, 2024

I'm on this @dmitryax

atoulme added a commit to atoulme/opentelemetry-collector that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants