Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[chore] change the way we unmarshal the config in tests" #9771

Merged
merged 1 commit into from Mar 15, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 15, 2024

Reverts #9765

We need to revert those changes as contrib has issues with them in isolation from #9750.

@atoulme atoulme requested a review from a team as a code owner March 15, 2024 16:16
@atoulme atoulme requested a review from dmitryax March 15, 2024 16:16
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (eb5d2b9) to head (1fe9ed3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9771   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         353      353           
  Lines       18635    18635           
=======================================
  Hits        16957    16957           
  Misses       1352     1352           
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten
Copy link
Contributor

Should this revert not address these errors:

Error: ../../receiver/opencensusreceiver/factory.go:54:37: cannot use rCfg.NetAddr.Transport (variable of type confignet.TransportType) as string value in argument to newOpenCensusReceiver

@dmitryax
Copy link
Member

Should this revert not address these errors:

It should not. That one is part of #9385. I belive @TylerHelmuth is trying to update core dependency in contrib to fix it. and this is blocking it.

@dmitryax dmitryax merged commit 06f177a into main Mar 15, 2024
32 of 46 checks passed
@dmitryax dmitryax deleted the revert-9765-generated_unmarshal_changes branch March 15, 2024 16:54
@github-actions github-actions bot added this to the next release milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants