Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove telemetry.useOtelForInternalMetrics stable feature gate #9752

Merged
merged 2 commits into from Mar 14, 2024
Merged

[chore] Remove telemetry.useOtelForInternalMetrics stable feature gate #9752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34a218
[chore] Remove `telemetry.useOtelForInternalMetrics` stable feature gate
atoulme Mar 13, 2024
07cc29e
add changelog
atoulme Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/remove_stable_featuregate.yaml
View file
Open in desktop
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: telemetry

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove telemetry.useOtelForInternalMetrics stable feature gate

# One or more tracking issues or pull requests related to the change
issues: [9752]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
8 changes: 0 additions & 8 deletions internal/obsreportconfig/obsreportconfig.go
View file
Open in desktop
Expand Up @@ -7,14 +7,6 @@ import (
"go.opentelemetry.io/collector/featuregate"
)

// UseOtelForInternalMetricsfeatureGate is the feature gate that controls whether the collector uses open
// telemetrySettings for internal metrics.
var UseOtelForInternalMetricsfeatureGate = featuregate.GlobalRegistry().MustRegister(
"telemetry.useOtelForInternalMetrics",
featuregate.StageStable,
featuregate.WithRegisterDescription("controls whether the collector uses OpenTelemetry for internal metrics"),
featuregate.WithRegisterToVersion("0.95.0"))

// DisableHighCardinalityMetricsfeatureGate is the feature gate that controls whether the collector should enable
// potentially high cardinality metrics. The gate will be removed when the collector allows for view configuration.
var DisableHighCardinalityMetricsfeatureGate = featuregate.GlobalRegistry().MustRegister(
Expand Down