[confmap] Remove provider.New #9698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9698 +/- ##
==========================================
- Coverage 90.93% 90.93% -0.01%
==========================================
Files 348 348
Lines 18379 18369 -10
==========================================
- Hits 16713 16703 -10
Misses 1344 1344
Partials 322 322 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Mar 6, 2024
|
@atoulme can you please update the contrib to make tests pass? |
|
Yes, I will. |
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 6, 2024
**Description:** Remove use of fileprovider.New, use fileprovider.NewWithSettings instead **Link to tracking Issue:** See open-telemetry/opentelemetry-collector#9698
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Remove use of fileprovider.New, use fileprovider.NewWithSettings instead **Link to tracking Issue:** See open-telemetry/opentelemetry-collector#9698
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Remove use of fileprovider.New, use fileprovider.NewWithSettings instead **Link to tracking Issue:** See open-telemetry/opentelemetry-collector#9698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to #9443 - deleting the deprecated
Newmethods on providers.