Add Windows zip #375
Open
Add Windows zip #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Jul 26, 2023
|
@jpkrohling Is it possible to merge it to the next version (0.84.0)? |
|
I'll close and open this PR again, in an attempt to retrigger the CI: it has failed with a disk space issue, which I'm hoping is not tied to this PR. |
|
@jpkrohling no space left on device |
|
Can you check what are the disk requirements before and after this change? Are we just too close to the limit on the main branch, or is this change here causing too much usage? |
codeboten
reviewed
Sep 12, 2023
|
@codeboten @jpkrohling I added |
|
@jpkrohling @codeboten all checks have passed... |
|
would you please look at the conflicts? |
|
Needs a rebase |
|
@ShiranAvidov please let us know if you would like to work to resolve conflicts on this PR, otherwise we will close it for inactivity in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new Build and Archive for Windows, so each release will have Windows tar.gz and zip files.
#373