Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency for configuration for distros #530

Open
codeboten opened this issue Apr 17, 2024 · 3 comments
Open

Consistency for configuration for distros #530

codeboten opened this issue Apr 17, 2024 · 3 comments

Comments

@codeboten
Copy link
Contributor

Configuration is in different places for the different distros:

# contrib
/etc/otelcol-contrib/config.yaml
# core
/etc/otelcol/config.yaml
# k8s distro
No conf

It would be great to have it be consistent

@mx-psi
Copy link
Member

mx-psi commented Apr 17, 2024

This was intentional #59 (comment)

I don't like having a default config because:

  • It leads to a silent failure (using the default config) if you get the command wrong/mount the config in the wrong place
  • The default config is not useful outside of a demo, it just uses the debug exporter. Additionally, I don't think any config would be helpful, we can't really predict users use case here

Although removing the default config is a breaking change, the blast radius is probably going to be more reduced (at least if we keep the entrypoint as is), since most people are not using the default configuration

@TylerHelmuth
Copy link
Member

I agree on removing default config

@jpkrohling
Copy link
Member

I'm also in favor of removing the default config.

It leads to a silent failure (using the default config) if you get the command wrong/mount the config in the wrong place

I've seen this many times as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants