Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the command name consistent across images #528

Open
dmitryax opened this issue Apr 16, 2024 · 8 comments
Open

Make the command name consistent across images #528

dmitryax opened this issue Apr 16, 2024 · 8 comments

Comments

@dmitryax
Copy link
Member

dmitryax commented Apr 16, 2024

Currently, we use different commands for different images.

  • /otelcol for the core image
  • /otelcol-contrib for the contrib image (/otecontribcol if built with make docker-otelcontribcol)
  • /otelcol-k8s for k8s image

Is there any value to having a unique command in each distro?

If not, we could use /otelcol consistently for every image.

We can make this change gradually and support both old and new names for some time.

Initially brought in open-telemetry/opentelemetry-helm-charts#1148 (comment)

@mx-psi
Copy link
Member

mx-psi commented Apr 17, 2024

cc @jpkrohling

@codeboten
Copy link
Contributor

The different configuration files is also confusing..

@codeboten
Copy link
Contributor

As discussed in 17-Apr-2024 - The same command could just be a symlink to ensure the change isn't breaking backwards compatibility

@codeboten
Copy link
Contributor

Opened a separate issue for configuration consistency: #530

@mx-psi
Copy link
Member

mx-psi commented Apr 17, 2024

I pinged Juraci because I think this was intentional (see #59 (comment))

@TylerHelmuth
Copy link
Member

@dmitryax if we wanted to take advantage of the entrypoint in the helm chart like @jaronoff97 mentioned we'll need to update the container to use args instead of command.

@TylerHelmuth
Copy link
Member

Created open-telemetry/opentelemetry-helm-charts#1149 for the helm chart.

@jpkrohling
Copy link
Member

The idea behind both the config files being at different locations, and the binary names being different, is that different distributions could be installed via OS packages (rpm/deb) without interfering. From here, we have a few options:

  • continue allowing multiple distributions to be installed on the same system independently
  • make them all providers of a capability, like the Provides keyword for RPM, meaning that only one such package is allowed at any given time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants