[pkg/ottl] Add day, month, and year converters #33120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have converters for the minute/hour of a `time.Time`, but we don't have them for the rest of the components. This implements them using the existing time.Time methods. This is useful for things like `day-month-year` named files using the new functionality of the file exporter. Signed-off-by: sinkingpoint <colin@quirl.co.nz>
Signed-off-by: sinkingpoint <colin@quirl.co.nz>
sinkingpoint
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
sinkingpoint
changed the title
|
@sinkingpoint Thanks for doing this, can you break it into 1 PR per converter? |
|
Sure. Do I need a seperate change log entry for each as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds in three new ottl converters,
Day,Month, andYear, which can be used to extract their respective components from atime.TimeLink to tracking Issue: #33106
Testing: Added unit tests for each, based on the existing converter,
HourDocumentation: Added each to the
README.mdfor ottl