Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awss3receiver] Add obsreport usage for receiver metrics #33110

Merged
merged 5 commits into from
May 23, 2024

Conversation

adcharre
Copy link
Contributor

Description: Add metrics using obsreport to the S3 receiver

Link to tracking Issue: #30750

Testing: Full stack test, confirmed otelcol_receiver_accepted_spans and otelcol_receiver_refused_spans was being exported for the awss3 receiver.

Documentation: None

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented May 19, 2024

Sorry please resolve conflicts.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label May 20, 2024
@andrzej-stencel
Copy link
Member

Can you please fix the conflicts @adcharre

@andrzej-stencel andrzej-stencel removed the ready to merge Code review completed; ready to merge by maintainers label May 22, 2024
@adcharre
Copy link
Contributor Author

Can you please fix the conflicts @adcharre

@andrzej-stencel - done

@andrzej-stencel andrzej-stencel merged commit 6f477ff into open-telemetry:main May 23, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants