[exporter/kafkaexporter] added an option to disable kerberos PA-FX-FAST negotiation #33086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
May 19, 2024
|
It looks like the file needs to formatted before it can be merged, do you mind @sy-be sorting that out? |
|
@MovieStoreGuy , thanks for looking! I have updated the PR with linter fixes (a missing newline). Could you please rerun the workflows? Thanks! |
|
@MovieStoreGuy, @dmitryax, @atoulme can anyone please take a look at this? 🙏 Thanks! |
crobert-1
reviewed
May 31, 2024
exporter/kafkaexporter/README.md
Outdated
| @@ -68,6 +68,7 @@ The following settings can be optionally configured: | |||
| - `password`: The Kerberos password used for authenticate with KDC | |||
| - `config_file`: Path to Kerberos configuration. i.e /etc/krb5.conf | |||
| - `keytab_file`: Path to keytab file. i.e /etc/security/kafka.keytab | |||
| - `disable_fast_negotiation`: Disable PA-FX-FAST negotiation (Pre-Authentication Framework - Fast). Some common Kerberos implementations do not support PA-FX-FAST negotiation. | |||
There was a problem hiding this comment.
Can you add a note in all of the READMEs that this is false by default?
Co-authored-by: Curtis Robert <crobert@splunk.com>
crobert-1
approved these changes
May 31, 2024
crobert-1
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the
disable_fast_negotiationconfiguration option for Kafka Kerberos authentication. This option allows users to disable the PA-FX-FAST negotiation, which can cause issues when Active Directory is not configured to support it. This change ensures that Kafka Exporters can function correctly in such environments.Link to tracking Issue: 26345
Testing:
disable_fast_negotiationoption in theKerberosConfigstruct.disable_fast_negotiationis set to bothtrueandfalse, ensuring that the configuration is correctly applied.Documentation:
disable_fast_negotiationconfiguration option.