[exporter/sumologicexporter]: adds support for tracing #33021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aboguszewski-sumo,
kkujawa-sumo,
mat-rumian,
rnishtala-sumo and
swiatekm-sumo
sumo-drosiek
force-pushed
the
drosiek-tracing
branch
from
fc35f67
to
08c7860
Compare
sumo-drosiek
changed the title
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-tracing
branch
from
08c7860
to
1b7686b
Compare
|
I hope this is the last one. I am going to be very happy about closing this saga 🤞 |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
swiatekm-sumo
approved these changes
May 15, 2024
songy23
reviewed
May 16, 2024
songy23
approved these changes
May 17, 2024
|
cc: @open-telemetry/collector-contrib-approvers |
crobert-1
reviewed
May 20, 2024
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
crobert-1
approved these changes
May 21, 2024
| @@ -99,7 +101,7 @@ exporters: | |||
| decompose_otlp_histograms: {true, false} | |||
|
|
|||
| # timeout is the timeout for every attempt to send data to the backend, | |||
| # maximum connection timeout is 55s, default = 5s | |||
| # maximum connection timeout is 55s, default = 30s | |||
There was a problem hiding this comment.
Is this maximum connection timeout ever enforced or tested? It's unrelated to this PR, so no need to do anything now, just something to consider if it's not currently enforced.
There was a problem hiding this comment.
I don't think we test it
Created issue so we can keep track of it: #33151
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adds support for tracing
It should be the last PR which moves code from Sumo Logic repository. I will compare the codebase after merging it
Link to tracking Issue:
#32315
Testing:
Documentation: