Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector usage to the testbed #32881

Merged
merged 19 commits into from May 10, 2024
Merged

Conversation

humivo
Copy link
Member

@humivo humivo commented May 7, 2024

Description: Added a new component to the testbed called DataConnectors which allows connectors to be added to the testbed config. Also, added a sample connector correctness test using the routingconnector as an example of the usage.

Link to tracking Issue: #30165

Testing: Sample correctness test using routingconnector.

Documentation: Will update the testbed README with new addition.

@humivo humivo requested a review from a team as a code owner May 7, 2024 00:41
@humivo humivo changed the title Testbed connector Add connector usage to the testbed May 7, 2024
@humivo
Copy link
Member Author

humivo commented May 8, 2024

This PR with the same changes was previously approved by @mx-psi but was just awaiting merge conflicts. I have reopened the PR with fixes to merge conflicts here and awaiting review/approval to merge.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @djaglowski in case you want to review

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @humivo

testbed/dataconnectors/routing.go Show resolved Hide resolved
@bryan-aguilar bryan-aguilar added the ready to merge Code review completed; ready to merge by maintainers label May 10, 2024
@mx-psi mx-psi merged commit fba8658 into open-telemetry:main May 10, 2024
169 checks passed
@github-actions github-actions bot added this to the next release milestone May 10, 2024
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this pull request May 14, 2024
**Description:** Added a new component to the testbed called
DataConnectors which allows connectors to be added to the testbed
config. Also, added a sample connector correctness test using the
routingconnector as an example of the usage.

**Link to tracking Issue:** open-telemetry#30165 

**Testing:** Sample correctness test using routingconnector.

**Documentation:** Will update the testbed README with new addition.

---------

Co-authored-by: Bryan Aguilar <bryaag@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers testbed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants