[receiver/mysql] feat: add table size metrics #32680
Conversation
|
Is there a corresponding issue for this PR? |
No, I didn’t see an existing one. However, I've just created a new one: #32693 |
s-v-a-n
changed the title
s-v-a-n
force-pushed
the
table-size-metric
branch
from
3c32f3d
to
47aa445
Compare
s-v-a-n
force-pushed
the
table-size-metric
branch
4 times, most recently
from
3bb8959
to
2027133
Compare
|
@djaglowski I've updated the PR to clean it up. Please review. Thank you |
s-v-a-n
force-pushed
the
table-size-metric
branch
2 times, most recently
from
4af2bc5
to
3d8aa8a
Compare
receiver/mysqlreceiver/metadata.yaml
Outdated
| mysql.table.total_length: | ||
| enabled: false | ||
| description: The total length (sum of data_length and index_length) in bytes for a given table. | ||
| unit: By | ||
| sum: | ||
| value_type: int | ||
| monotonic: false | ||
| aggregation_temporality: cumulative | ||
| attributes: [table_name, schema] | ||
| mysql.table.data_length: | ||
| enabled: false | ||
| description: The data length in bytes for a given table. | ||
| unit: By | ||
| sum: | ||
| value_type: int | ||
| monotonic: false | ||
| aggregation_temporality: cumulative | ||
| attributes: [table_name, schema] | ||
| mysql.table.index_length: | ||
| enabled: false | ||
| description: The index length in bytes for a given table. | ||
| unit: By | ||
| sum: | ||
| value_type: int | ||
| monotonic: false | ||
| aggregation_temporality: cumulative | ||
| attributes: [table_name, schema] |
There was a problem hiding this comment.
Can we just model this as one metric with two data points and an attribute which is either data or index? This is how OTel's data model is intended to work, rather than just returning sums as separate metrics.
There was a problem hiding this comment.
Yes, that makes sense. I'll remove the total_length metric.
There was a problem hiding this comment.
We still have separate metrics for data and index length. The problem with this is that it is now difficult for users to combine the two in most backends. OTel typically will combine these into one metric and use an attribute to differentiate between the two. Any reason not to do this?
There was a problem hiding this comment.
Also, typically can we name this metric mysql.table.size?
There was a problem hiding this comment.
I misunderstood your last comment. I'll have that changed. Thank you for the review!
There was a problem hiding this comment.
I still see two separate metrics
There was a problem hiding this comment.
@djaglowski Please check now. Thank you
There was a problem hiding this comment.
@djaglowski Checking in - please let me now if there needs additional changes
s-v-a-n
force-pushed
the
table-size-metric
branch
7 times, most recently
from
b93c042
to
6cfa283
Compare
s-v-a-n
force-pushed
the
table-size-metric
branch
from
6cfa283
to
43feb9a
Compare
s-v-a-n
force-pushed
the
table-size-metric
branch
from
43feb9a
to
5437618
Compare
Description: This adds table size metrics using the INFORMATION_SCHEMA TABLES table: https://dev.mysql.com/doc/refman/8.3/en/information-schema-tables-table.html. Specifically, we are adding the columns:
TABLE_ROWS,AVG_ROW_LENGTH,DATA_LENGTH,INDEX_LENGTHLink to tracking issue: #32693
Testing: Added testing data, tested locally against MySQL 8.
Documentation: By default, the metric is turned off. When enabled, make sure that the MySQL user has access to the tables being monitored.