Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update test for confmap changes #32660

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Apr 24, 2024

Description:
Update test to be compatible with confmap changes to unmarshal via confmap first

mx-psi
mx-psi previously approved these changes Apr 24, 2024
@mx-psi mx-psi dismissed their stale review April 24, 2024 08:24

Failing tests

@mx-psi
Copy link
Member

mx-psi commented Apr 24, 2024

Doesn't look like this worked 🤔

@atoulme
Copy link
Contributor Author

atoulme commented Apr 25, 2024

This passes if core applies open-telemetry/opentelemetry-collector#9862.

@mx-psi
Copy link
Member

mx-psi commented Apr 26, 2024

This passes if core applies open-telemetry/opentelemetry-collector#9862.

Oh, okay, so we need to merge the two PRs together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants