[pkg/stanza] Fix TimeParser unmarshaling #32568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
time_parser_take2
branch
from
aa1badd
to
05fa51c
Compare
djaglowski
approved these changes
Apr 20, 2024
LokeshOpsramp
pushed a commit
to opsramp/opentelemetry-collector-contrib
that referenced
this pull request
May 5, 2024
**Description:** Fix unmarshaling of TimeParser to conserve initial settings before unmarshaling. **Link to tracking Issue:** Fixes open-telemetry#32169 **Testing:** Added the test from the issue. For @mx-psi I could not make it so we would apply open-telemetry#31802 (comment) because `TimeParser` is reused on all operators, and therefore it becomes contentious to patch all over the place.
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
**Description:** Fix unmarshaling of TimeParser to conserve initial settings before unmarshaling. **Link to tracking Issue:** Fixes open-telemetry#32169 **Testing:** Added the test from the issue. For @mx-psi I could not make it so we would apply open-telemetry#31802 (comment) because `TimeParser` is reused on all operators, and therefore it becomes contentious to patch all over the place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix unmarshaling of TimeParser to conserve initial settings before unmarshaling.
Link to tracking Issue:
Fixes #32169
Testing:
Added the test from the issue.
For @mx-psi I could not make it so we would apply #31802 (comment) because
TimeParseris reused on all operators, and therefore it becomes contentious to patch all over the place.