Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix linting #32004

Merged
merged 2 commits into from Mar 27, 2024
Merged

[chore] fix linting #32004

merged 2 commits into from Mar 27, 2024

Conversation

led0nk
Copy link
Contributor

@led0nk led0nk commented Mar 27, 2024 •
edited

Description:
This PR should solve the related Issue linked below.
I tried to switch to blank identifiers instead of removing function arguments, so it could be adapted later on.

linting erros in following pkgs:

  • cmd/configschema
  • cmd/githubgen
  • connector/datadogconnector
  • connector/grafanacloudconnector
  • connector/servicegraphconnector
  • exporter/awsemfexporter
  • exporter/awsxrayexporter
  • exporter/clickhouseexporter
  • exporter/datadogexporter
  • exporter/dynatraceexporter
  • exporter/elasticsearchexporter
  • exporter/honeycombmarkerexporter
  • exporter/influxdbexporter
  • exporter/instanaexporter
  • exporter/kafkaexporter
  • exporter/kineticaexporter
  • exporter/loadbalancingexporter
  • exporter/logicmonitorexporter
  • exporter/logzioexporter
  • exporter/lokiexporter
  • exporter/mezmoexporter
  • exporter/opensearchexporter
  • exporter/prometheusexporter
  • exporter/signalfxexporter
  • exporter/splunkhecexporter
  • exporter/sumologicexporter
  • exporter/zipkinexporter
  • extension/jaegerremotesampling
  • extension/oauth2clientauthextension
  • extension/observer
  • extension/oidcauthextension
  • extension/sumologicextension
  • internal/aws
  • internal/coreinternal
  • internal/filter
  • internal/kubelet
  • internal/metadataproviders
  • internal/sharedcomponent
  • pkg/ottl
  • pkg/pdatautil
  • pkg/stanza
  • pkg/translator
  • processor/deltatocumulativeprocessor
  • processor/filterprocessor
  • processor/groupbytraceprocessor
  • processor/k8sattributesprocessor
  • processor/logstransformprocessor
  • processor/metricstransformprocessor
  • processor/resourcedetectionprocessor
  • processor/tailsamplingprocessor
  • processor/transformprocessor
  • receiver/awscontainerinsightreceiver
  • receiver/chronyreceiver
  • receiver/splunkhecreceiver
  • receiver/sqlqueryreceiver
  • receiver/vcenterreceiver
  • receiver/webhookeventreceiver
  • receiver/zookeeperreceiver

Link to tracking Issue:

Testing:

Documentation:

@led0nk led0nk changed the title Fix linting [chore] fix linting Mar 27, 2024
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 27, 2024
songy23
songy23 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @led0nk !

@djaglowski djaglowski merged commit 465144e into open-telemetry:main Mar 27, 2024
147 of 148 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@led0nk led0nk deleted the fix-linting branch March 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@songy23 songy23 songy23 approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@arminru arminru Awaiting requested review from arminru

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar bryan-aguilar is a code owner

Assignees

@jpkrohling jpkrohling

Labels
cmd/configschema configschema command cmd/githubgen connector/datadog connector/grafanacloud connector/servicegraph exporter/awsemf awsemf exporter exporter/awsxray exporter/clickhouse exporter/datadog Datadog components exporter/dynatrace exporter/elasticsearch exporter/honeycombmarker exporter/influxdb exporter/instana exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opensearch exporter/prometheus exporter/prometheusremotewrite exporter/signalfx exporter/splunkhec exporter/sumologic exporter/zipkin extension/jaegerremotesampling extension/oauth2clientauth extension/observer extension/oidcauth extension/sumologic internal/aws internal/core internal/filter internal/kubelet internal/metadataproviders internal/sharedcomponent pkg/ottl Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@led0nk @atoulme @songy23 @jpkrohling @djaglowski @frzifus